Review Request 112874: Allow disabling of QCA plugins during build.

[Ivan Romanov]

> On Oct. 13, 2013, 11:03 p.m., Ivan Romanov wrote:
> > Two issues.
> > 
> > 1. all means all possible not all of them. If I haven't nss on my system qca-nss plugin won't built but all others will be built.
> > 2. In INSTALL instructions. 
> > 
> >   BUILD_PLUGINS - define which plugins should be built in a semicolon
> >                   separated list or "all" if you want to build all of
> >                   them (by default: "")
> > 
> > must be
> >   BUILD_PLUGINS - define which plugins should be built in a semicolon
> >                   separated list or "all" if you want to build all *possible* of
> >                   them (by default: "*all*")
> > 
> >

I wrote own patch to implement this. http://commits.kde.org/qca/094899a00cd20796ecbfa463a08c5179c104f83d . So this review request can/should be closed.


- Ivan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112874/#review41650
-----------------------------------------------------------


On Oct. 13, 2013, 8:06 p.m., Uwe L. Korn wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112874/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2013, 8:06 p.m.)
> 
> 
> Review request for KDE Frameworks and Ivan Romanov.
> 
> 
> Repository: qca
> 
> 
> Description
> -------
> 
> Add the ability to disable plugins, e.g. do not build the openssl plugins although OpenSSL was found in the system. This is a requirement that arose during packaging latest head for Gentoo.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt bdb77b4 
>   INSTALL cf847a0 
>   plugins/CMakeLists.txt 6e8a7a2 
>   plugins/qca-botan/CMakeLists.txt 1b9607c 
>   plugins/qca-cyrus-sasl/CMakeLists.txt b36cbcf 
>   plugins/qca-gcrypt/CMakeLists.txt f5c73bd 
>   plugins/qca-gnupg/CMakeLists.txt 7f46abf 
>   plugins/qca-nss/CMakeLists.txt 805567d 
>   plugins/qca-ossl/CMakeLists.txt 6b5c69c 
>   plugins/qca-pkcs11/CMakeLists.txt b220926 
>   plugins/qca-wincrypto/CMakeLists.txt c0ab378 
> 
> Diff: http://git.reviewboard.kde.org/r/112874/diff/
> 
> 
> Testing
> -------
> 
> Compiled, installed and used on Gentoo (with Qt5).
> 
> 
> Thanks,
> 
> Uwe L. Korn
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131111/e886fff3/attachment.html>