Review Request 113723: Fix KIO to build standalone, prepare for moving into its tier
David Faure
faure at kde.org
Mon Nov 11 12:04:57 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113723/#review43421
-----------------------------------------------------------
Ship it!
Ship It!
- David Faure
On Nov. 11, 2013, 11:40 a.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113723/
> -----------------------------------------------------------
>
> (Updated Nov. 11, 2013, 11:40 a.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kdelibs
>
>
> Description
> -------
>
> As you will see, this splitting was a bit harder than others:
> - KIO was using a couple of private headers from kjobwidgets, which now they will be installed.
> - The xslt_kde target was being used from KDocTools without having it exported. Now it will be properly exported.
> - Also defines all dependencies so it can be compiled independently, modularization is done as well.
>
>
> Diffs
> -----
>
> cmake/modules/CMakeLists.txt 07f7eac
> cmake/modules/FindGSSAPI.cmake
> staging/kio/CMakeLists.txt 6c7297e
> staging/kio/src/filewidgets/CMakeLists.txt 31fe8c6
> staging/kio/src/ioslaves/help/CMakeLists.txt 40637dc
> staging/kio/src/ioslaves/http/kcookiejar/CMakeLists.txt 2630f01
> staging/kio/src/ioslaves/http/tests/CMakeLists.txt 52c9f6c
> staging/kio/src/widgets/CMakeLists.txt d90386d
> staging/kio/src/widgets/kopenwithdialog.cpp cb4fc0f
> staging/kio/tests/CMakeLists.txt 6cee291
> superbuild/CMakeLists.txt 53f5952
> tier1/kcoreaddons/src/lib/CMakeLists.txt 4e6e206
> tier2/kdoctools/CMakeLists.txt c2256ff
> tier2/kdoctools/KDocToolsConfig.cmake d501dc8
> tier2/kdoctools/KDocToolsConfig.cmake.in PRE-CREATION
> tier2/kdoctools/src/CMakeLists.txt 3940e98
>
> Diff: http://git.reviewboard.kde.org/r/113723/diff/
>
>
> Testing
> -------
>
> Builds, Installs, tests still pass; both modularized and monolithic kdelibs.
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131111/4dfb1527/attachment.html>
More information about the Kde-frameworks-devel
mailing list