Review Request 113704: Fix EPS plugin

[Alex Merry]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113704/
-----------------------------------------------------------

(Updated Nov. 10, 2013, 7:05 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kdelibs


Description
-------

4 commits.  Previously, writing support was completely broken (it would write a PDF file instead of an EPS file).  The rest of the changes mostly make it more maintainable.


Disable EPS plugin on non-UNIX systems

It depends on the gs command-line utility being in PATH, which is
unlikely on Windows, for example.


Use QProcess to run gs when reading EPS images


Fix writing EPS files

QPrinter is no longer capable of producing PostScript files, so we
output to PDF then used GhostScript (or pdftops from Poppler) to convert
the result to EPS.  Note that GhostScript is already used by the reading
code.


Use qCDebug for the EPS plugin


Diffs
-----

  tier1/kguiaddons/src/plugins/imageformats/CMakeLists.txt 005859ac6fd792f2589339bc68437dd2d965cc8f 
  tier1/kguiaddons/src/plugins/imageformats/eps.cpp cb25052a9d7a01ea7a8ed8014726b762e8a5da16 

Diff: http://git.reviewboard.kde.org/r/113704/diff/


Testing
-------

Successfully converted a JPG file to EPS and back again; both the final JPG and the intermediate EPS file display properly with Gwenview/Okular from KDE SC 4.  This works both with pdftops present in PATH and without it (providing gs is in PATH).


Thanks,

Alex Merry

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131110/e58eabdc/attachment-0001.html>