Review Request 113730: Fix kpty standalone build

David Faure faure at kde.org
Sun Nov 10 12:53:07 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113730/#review43337
-----------------------------------------------------------

Ship it!


Ship It!

- David Faure


On Nov. 9, 2013, 10:54 a.m., Maarten De Meyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113730/
> -----------------------------------------------------------
> 
> (Updated Nov. 9, 2013, 10:54 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> Make kpty build standalone and with superbuild.
> 
> I'm not sure if installing kprocess_p.h is the correct solution.
> 
> 
> Diffs
> -----
> 
>   superbuild/CMakeLists.txt 80de8667b338c91922f627eaf92073a9a51645d8 
>   tier1/kcoreaddons/src/lib/CMakeLists.txt fad55c56bea27fe26916bf5a7cbef612613578fd 
>   tier3/kpty/CMakeLists.txt f96ecabd729aea9f48e89ccc222517096487d780 
>   tier3/kpty/src/ConfigureChecks.cmake a385e17276d8f9a3598f1434bd0da5e8b25f0218 
>   tier3/kpty/tests/CMakeLists.txt f78e3fe105aae313dcb5eeb7524c12a8e8533bf0 
> 
> Diff: http://git.reviewboard.kde.org/r/113730/diff/
> 
> 
> Testing
> -------
> 
> Builds.
> 
> 
> Thanks,
> 
> Maarten De Meyer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131110/88dbb40a/attachment.html>


More information about the Kde-frameworks-devel mailing list