Review Request 113685: New KColorSchemeManager to support changing color scheme in app

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113685/#review43324
-----------------------------------------------------------


I like the overall concept and implementation.


tier3/kconfigwidgets/src/kcolorscheme.h
<http://git.reviewboard.kde.org/r/113685/#comment31199>

    Wouldn't "Oxygen" be translated, normally?
    
    If so, isn't this bad API, giving a translated name and hoping to find it in a list?
    
    Or is this the non-translated name used as a key, and the widget displays translated names? That's how it should be, but "const QString &text" makes me think it's not how it is :)



tier3/kconfigwidgets/src/kcolorscheme.cpp
<http://git.reviewboard.kde.org/r/113685/#comment31201>

    Please move this class to its own .cpp and .h files.



tier3/kconfigwidgets/src/kcolorschememanager_p.h
<http://git.reviewboard.kde.org/r/113685/#comment31195>

    Use Q_DECL_OVERRIDE instead of override, see http://community.kde.org/Frameworks/C++11



tier3/kconfigwidgets/src/kcolorschememanager_p.h
<http://git.reviewboard.kde.org/r/113685/#comment31196>

    I'm curious, why not just by value?



tier3/kconfigwidgets/src/kcolorschememanager_p.cpp
<http://git.reviewboard.kde.org/r/113685/#comment31197>

    is "QString" really longer to type than auto? :-)
    
    I get the point of auto to replace long iterator type definitions, but for QString or QStringList? It just makes the code harder to read imho.



tier3/kconfigwidgets/src/kcolorschememanager_p.cpp
<http://git.reviewboard.kde.org/r/113685/#comment31200>

    I wonder if this C++11 syntax is supported by all the supported compilers, it's not listed at http://community.kde.org/Frameworks/C++11, so I think it shouldn't be used.


- David Faure


On Nov. 6, 2013, 3:22 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113685/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2013, 3:22 p.m.)
> 
> 
> Review request for KDE Frameworks, Gilles Caulier and Boudewijn Rempt.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> This class is inspired by functionality offered by e.g. Krita and
> Digikam to allow the user to select a different color scheme for the
> application.
>     
> This manager simplifies this task and also ensures that the required
> property on QApplication is set, so that a QStyle can pass the scheme
> to the window manager/compositor for the windows of the application.
> 
> @boud and @cgilles: please have a look whether this approach is sufficient for your usecases in digkam and Krita.
> 
> 
> Diffs
> -----
> 
>   tier3/kconfigwidgets/src/CMakeLists.txt 36ffca8 
>   tier3/kconfigwidgets/src/kcolorscheme.h 43da913 
>   tier3/kconfigwidgets/src/kcolorscheme.cpp 62326a6 
>   tier3/kconfigwidgets/src/kcolorschememanager_p.h PRE-CREATION 
>   tier3/kconfigwidgets/src/kcolorschememanager_p.cpp PRE-CREATION 
>   tier3/kconfigwidgets/tests/CMakeLists.txt f66dc32 
>   tier3/kconfigwidgets/tests/kcolorschemedemo.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/113685/diff/
> 
> 
> Testing
> -------
> 
> see demo application
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131110/2f8a0c29/attachment-0001.html>