Review Request 113670: Only link to Qt5::X11Extras and ${X11_LIBRARIES} if X11 was found

[Alexander Richardson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113670/
-----------------------------------------------------------

(Updated Nov. 8, 2013, 10:04 p.m.)


Review request for KDE Frameworks.


Changes
-------

Only link to X11 stuff if X11 was found


Summary (updated)
-----------------

Only link to Qt5::X11Extras and ${X11_LIBRARIES} if X11 was found


Repository: kdelibs


Description
-------

Link kde4support privately to QtX11Extras, QtSvg and QtTest

Otherwise every user of the target KF5::KDE4Support will also have
Qt5::X11Extras Qt5::Svg Qt5::Test linked.

This can cause linker errors like "ld: cannot find -lQt5::Test"

REVIEW: 113670


Diffs (updated)
-----

  tier4/kde4support/src/CMakeLists.txt cbfac3e 
  tier4/kde4support/src/kdeui/kxerrorhandler.h babf931 
  tier4/kde4support/src/kdeui/kxerrorhandler.cpp 3f4765d 

Diff: http://git.reviewboard.kde.org/r/113670/diff/


Testing
-------

I previously got the following error compiling okteta, now it works:
/usr/lib64/gcc/x86_64-suse-linux/4.7/../../../../x86_64-suse-linux/bin/ld: cannot find -lQt5::X11Extras
/usr/lib64/gcc/x86_64-suse-linux/4.7/../../../../x86_64-suse-linux/bin/ld: cannot find -lQt5::Svg

QtX11Info and QtSvg are not used in any installed headers, so IMO this should be fine
qtest_kde.h does actually include QtTest headers, but only uses these types inside macros. And I guess any user of that header already also links to QtTest


Thanks,

Alexander Richardson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131108/fddc0532/attachment-0001.html>