Review Request 113702: Fix KEmoticons standalone build

[Aurélien Gâteau]

> On Nov. 7, 2013, 1:47 p.m., Aurélien Gâteau wrote:
> > superbuild/CMakeLists.txt, line 34
> > <http://git.reviewboard.kde.org/r/113702/diff/1/?file=211375#file211375line34>
> >
> >     kemoticons should be listed after kservice, otherwise superbuild won't pick up the standalone version of it.
> >     
> >     /me goes documenting this
> 
> Maarten De Meyer wrote:
>     Yes. I noticed when making superbuild. Already fixed here.
>     Do you want me to upload a new diff?

No it's OK, I trust you.


- Aurélien


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113702/#review43216
-----------------------------------------------------------


On Nov. 7, 2013, 11:47 a.m., Maarten De Meyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113702/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2013, 11:47 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> Make KEmoticons build standalone.
> 
> 
> Diffs
> -----
> 
>   superbuild/CMakeLists.txt 90688f6 
>   tier3/kemoticons/CMakeLists.txt bc2812b 
>   tier3/kemoticons/autotests/CMakeLists.txt c88a288 
>   tier3/kemoticons/src/core/CMakeLists.txt 556d9bb 
> 
> Diff: http://git.reviewboard.kde.org/r/113702/diff/
> 
> 
> Testing
> -------
> 
> Builds.
> KCoreAddons is pulled in by KService
> 
> 
> Thanks,
> 
> Maarten De Meyer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131108/82822bda/attachment.html>