Review Request 113694: Fix KNewStuff standalone build

Àlex Fiestas afiestas at kde.org
Fri Nov 8 12:13:30 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113694/#review43256
-----------------------------------------------------------

Ship it!


Looks good, builds standalone and with frameworks.

- Àlex Fiestas


On Nov. 7, 2013, 1:04 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113694/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2013, 1:04 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> Adds dependencies to make sure KNewStuff can be compiled alone
> 
> 
> Diffs
> -----
> 
>   superbuild/CMakeLists.txt 90688f6 
>   tier3/knewstuff/CMakeLists.txt f7f4dfa 
> 
> Diff: http://git.reviewboard.kde.org/r/113694/diff/
> 
> 
> Testing
> -------
> 
> Builds and installs. All tests are commented out.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131108/c76fce2f/attachment.html>


More information about the Kde-frameworks-devel mailing list