Review Request 113712: Add popup for window with SkipTaskbar set in kpassivepopuptest

Alex Merry kde at randomguy3.me.uk
Fri Nov 8 12:12:48 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113712/
-----------------------------------------------------------

(Updated Nov. 8, 2013, 12:12 p.m.)


Review request for KDE Frameworks.


Changes
-------

Remove X11 libs from target_link_libraries.


Repository: kdelibs


Description
-------

Add popup for window with SkipTaskbar set in kpassivepopuptest

KPassivePopup should place this next to the window itself.


Diffs (updated)
-----

  tier2/knotifications/tests/kpassivepopuptest.cpp 266842aa336793248663a15e19d4ba22c32ee412 
  tier2/knotifications/tests/kpassivepopuptest.h c9620b975295be6d59b974824d1cb4e08c860f6f 
  tier2/knotifications/tests/CMakeLists.txt ce87f1752856dcc0b37ef86fb3bfdbdaf4ef5685 
  tier2/knotifications/src/CMakeLists.txt cf312e028c323521504bd9ccd4c8f3f817e13497 
  tier2/knotifications/CMakeLists.txt 6df0022536436477cc9cd875e0bccd70e78d32d3 

Diff: http://git.reviewboard.kde.org/r/113712/diff/


Testing
-------

Builds, runs, new test does the right thing.


Thanks,

Alex Merry

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131108/0553ede0/attachment.html>


More information about the Kde-frameworks-devel mailing list