Review Request 113693: Fix KNotifyConfig standalone build
Alex Merry
kde at randomguy3.me.uk
Thu Nov 7 14:16:38 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113693/#review43226
-----------------------------------------------------------
tier3/knotifyconfig/CMakeLists.txt
<http://git.reviewboard.kde.org/r/113693/#comment31154>
Did I miss something? Why is CMake 3 relevant to these? KIO wasn't exporting its dependencies to KIOConfig.cmake properly until recently, but it should be doing so now.
- Alex Merry
On Nov. 7, 2013, 1:07 p.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113693/
> -----------------------------------------------------------
>
> (Updated Nov. 7, 2013, 1:07 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kdelibs
>
>
> Description
> -------
>
> Add the dependencies of dependencies.
> Small fixes.
>
>
> Diffs
> -----
>
> superbuild/CMakeLists.txt 90688f6
> tier3/knotifyconfig/CMakeLists.txt 8be2ceb
> tier3/knotifyconfig/tests/CMakeLists.txt 385ff70
>
> Diff: http://git.reviewboard.kde.org/r/113693/diff/
>
>
> Testing
> -------
>
> Builds, installs, the test seems to work.
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131107/e535444e/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list