Review Request 113527: Move KPassivePopup to KNotifications and fix placement

[Alex Merry]

> On Nov. 6, 2013, 3:37 p.m., Martin Gräßlin wrote:
> > tier1/kwidgetsaddons/src/kpassivepopup.h, line 203
> > <http://git.reviewboard.kde.org/r/113527/diff/2/?file=209112#file209112line203>
> >
> >     I was wondering why the width an height are set to 0: wouldn't it be better to return a QPoint?
> 
> Alex Merry wrote:
>     So that a single datatype can be passed to moveNear() whether it is a window or the corner of the desktop.  moveNear() will place the popup adjacent to, but not in, the rectangle it is given.
>     
>     Why defaultArea() is public API is a different question entirely.  LXR says no-one uses it, and I can't see any possible use for it.  I'll put making that private in as a separate review, since this isn't an API review.
> 
> Martin Gräßlin wrote:
>     that sounds good. And sorry for turning it into an API review. It was just that I spent several minutes on "wtf? why is the size set to 0???)

NP.  Can I get a ship it from either you or Kevin, then?


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113527/#review43156
-----------------------------------------------------------


On Nov. 6, 2013, 11:54 a.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113527/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2013, 11:54 a.m.)
> 
> 
> Review request for KDE Frameworks, Fredrik Höglund and Martin Gräßlin.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> Alternative to RR 113393.
> 
> Commit 1: Move KPassivePopup to KNotifications
> 
> As well as being a conceptual fit, KPassivePopup needs to do X11 magic,
> and this is a lot easier if it can make use of the KWindowSystem
> library.
> 
> 
> Commit 2: Fix KPassivePopup placement
> 
> The non-X11 code is largely untested.
> 
> 
> Diffs
> -----
> 
>   tier1/kwidgetsaddons/CMakeLists.txt 01bae90e235fae424f3af48fb95dc24286e60562 
>   tier1/kwidgetsaddons/src/CMakeLists.txt beb5ecad9e063936dea9ca38f42238988ca3f51b 
>   tier1/kwidgetsaddons/src/kpassivepopup.h d7cef3dd94713554010547001de6b4d81e3e2961 
>   tier1/kwidgetsaddons/src/kpassivepopup.cpp 663f63af413b7660c9c1b21af3e3ae4d7c424bbe 
>   tier1/kwidgetsaddons/tests/CMakeLists.txt d0140ea2489a629949b7022f310dcd6349c06f20 
>   tier1/kwidgetsaddons/tests/kpassivepopuptest.h  
>   tier1/kwidgetsaddons/tests/kpassivepopuptest.cpp 4e7138523bdbe4166bf0e899d39d9ae1f8b8b447 
>   tier2/knotifications/src/CMakeLists.txt 7f5a332d6650f998d72c97b7cfddd27362756b08 
>   tier2/knotifications/tests/CMakeLists.txt 6f3be50819ffef19644b77c397e5b4966d61abd6 
>   tier4/kde4support/tests/CMakeLists.txt b22e2e818fc13519318fa32de44f5d4a32301661 
> 
> Diff: http://git.reviewboard.kde.org/r/113527/diff/
> 
> 
> Testing
> -------
> 
> Test app (in tests/ folder) works as expected on X11: if _NET_WM_ICON_GEOMETRY is set and a window id is passed, the popup is placed by the taskbar entry; if it is not set, it is place by the window; if a window id is not passed, it is placed top left (avoiding any panels) on the desktop.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131106/c24a611a/attachment.html>