Review Request 113646: Fix KTextWidgets standalone build

[Aurélien Gâteau]

> On Nov. 5, 2013, 4:04 p.m., Aleix Pol Gonzalez wrote:
> > tier3/ktextwidgets/src/widgets/ktextedit.cpp, line 38
> > <http://git.reviewboard.kde.org/r/113646/diff/1/?file=209162#file209162line38>
> >
> >     Maybe Sonnet is not exporting the include directories properly?

I verified: Sonnet correctly exports its include dir as $CMAKE_INSTALL_PREFIX/include. Code using it is expected to prefix header filename with "sonnet/" in the #include directive.


- Aurélien


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113646/#review43068
-----------------------------------------------------------


On Nov. 5, 2013, 3:58 p.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113646/
> -----------------------------------------------------------
> 
> (Updated Nov. 5, 2013, 3:58 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> Fix KTextWidgets standalone build
> 
> Had to prefix Sonnet includes with sonnet/. Hope this is OK.
> 
> 
> Diffs
> -----
> 
>   superbuild/CMakeLists.txt f557c9d 
>   tier3/ktextwidgets/CMakeLists.txt daa83b2 
>   tier3/ktextwidgets/autotests/CMakeLists.txt 0c7d5b3 
>   tier3/ktextwidgets/src/CMakeLists.txt 2155d68 
>   tier3/ktextwidgets/src/widgets/ktextedit.cpp 6b035a4 
> 
> Diff: http://git.reviewboard.kde.org/r/113646/diff/
> 
> 
> Testing
> -------
> 
> Builds alone and as part of kdelibs.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131106/ca37cc6d/attachment.html>