Review Request 113650: Adopt ecm_generate_headers in KParts framework

Commit Hook null at kde.org
Wed Nov 6 13:35:13 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113650/#review43148
-----------------------------------------------------------


This review has been submitted with commit 60ef9f8b7ed7c72bb5fc432587dda83c1cc990c5 by Aleix Pol to branch frameworks.

- Commit Hook


On Nov. 6, 2013, 1:14 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113650/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2013, 1:14 p.m.)
> 
> 
> Review request for KDE Frameworks, Alexander Neundorf and Stephen Kelly.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> Generate the forward headers using the macro instead of crafting it into a loop.
> Install the CamelCase headers in prefix/includes/KParts.
> 
> 
> Diffs
> -----
> 
>   tier3/kparts/src/CMakeLists.txt 4c3de10 
> 
> Diff: http://git.reviewboard.kde.org/r/113650/diff/
> 
> 
> Testing
> -------
> 
> Built, everything installed ok.
> 
> Installed files:
> kde-devel at thinktatil:~/build-frameworks/kdelibs$ cat install_manifest.txt  | grep include | grep -i kparts
> /home/kde-devel/kde5/include/kparts_version.h
> /home/kde-devel/kde5/include/KParts/ListingExtension
> /home/kde-devel/kde5/include/KParts/PartManager
> /home/kde-devel/kde5/include/KParts/TextExtension
> /home/kde-devel/kde5/include/KParts/ScriptableExtension
> /home/kde-devel/kde5/include/KParts/HistoryProvider
> /home/kde-devel/kde5/include/KParts/BrowserExtension
> /home/kde-devel/kde5/include/KParts/BrowserInterface
> /home/kde-devel/kde5/include/KParts/MainWindow
> /home/kde-devel/kde5/include/KParts/BrowserOpenOrSaveQuestion
> /home/kde-devel/kde5/include/KParts/Event
> /home/kde-devel/kde5/include/KParts/BrowserRun
> /home/kde-devel/kde5/include/KParts/HtmlExtension
> /home/kde-devel/kde5/include/KParts/FileInfoExtension
> /home/kde-devel/kde5/include/KParts/StatusBarExtension
> /home/kde-devel/kde5/include/KParts/Part
> /home/kde-devel/kde5/include/KParts/Plugin
> /home/kde-devel/kde5/include/kparts/kparts_export.h
> /home/kde-devel/kde5/include/kparts/part.h
> /home/kde-devel/kde5/include/kparts/plugin.h
> /home/kde-devel/kde5/include/kparts/partmanager.h
> /home/kde-devel/kde5/include/kparts/mainwindow.h
> /home/kde-devel/kde5/include/kparts/event.h
> /home/kde-devel/kde5/include/kparts/browserextension.h
> /home/kde-devel/kde5/include/kparts/historyprovider.h
> /home/kde-devel/kde5/include/kparts/browserinterface.h
> /home/kde-devel/kde5/include/kparts/browserrun.h
> /home/kde-devel/kde5/include/kparts/statusbarextension.h
> /home/kde-devel/kde5/include/kparts/browseropenorsavequestion.h
> /home/kde-devel/kde5/include/kparts/scriptableextension.h
> /home/kde-devel/kde5/include/kparts/textextension.h
> /home/kde-devel/kde5/include/kparts/htmlextension.h
> /home/kde-devel/kde5/include/kparts/fileinfoextension.h
> /home/kde-devel/kde5/include/kparts/listingextension.h
> /home/kde-devel/kde5/include/kparts/componentfactory.h
> /home/kde-devel/kde5/include/kparts/genericfactory.h
> /home/kde-devel/kde5/include/kparts/factory.h
> /home/kde-devel/kde5/include/KDE/KParts/BrowserExtension
> /home/kde-devel/kde5/include/KDE/KParts/BrowserHostExtension
> /home/kde-devel/kde5/include/KDE/KParts/BrowserInterface
> /home/kde-devel/kde5/include/KDE/KParts/BrowserRun
> /home/kde-devel/kde5/include/KDE/KParts/ComponentFactory
> /home/kde-devel/kde5/include/KDE/KParts/DockMainWindow3
> /home/kde-devel/kde5/include/KDE/KParts/Event
> /home/kde-devel/kde5/include/KDE/KParts/Factory
> /home/kde-devel/kde5/include/KDE/KParts/FileInfoExtension
> /home/kde-devel/kde5/include/KDE/KParts/GUIActivateEvent
> /home/kde-devel/kde5/include/KDE/KParts/GenericFactory
> /home/kde-devel/kde5/include/KDE/KParts/GenericFactoryBase
> /home/kde-devel/kde5/include/KDE/KParts/HistoryProvider
> /home/kde-devel/kde5/include/KDE/KParts/HtmlExtension
> /home/kde-devel/kde5/include/KDE/KParts/LiveConnectExtension
> /home/kde-devel/kde5/include/KDE/KParts/ListingExtension
> /home/kde-devel/kde5/include/KDE/KParts/MainWindow
> /home/kde-devel/kde5/include/KDE/KParts/OpenUrlEvent
> /home/kde-devel/kde5/include/KDE/KParts/Part
> /home/kde-devel/kde5/include/KDE/KParts/PartActivateEvent
> /home/kde-devel/kde5/include/KDE/KParts/PartBase
> /home/kde-devel/kde5/include/KDE/KParts/PartManager
> /home/kde-devel/kde5/include/KDE/KParts/PartSelectEvent
> /home/kde-devel/kde5/include/KDE/KParts/Plugin
> /home/kde-devel/kde5/include/KDE/KParts/ReadOnlyPart
> /home/kde-devel/kde5/include/KDE/KParts/ReadWritePart
> /home/kde-devel/kde5/include/KDE/KParts/StatusBarExtension
> /home/kde-devel/kde5/include/KDE/KParts/TextExtension
> /home/kde-devel/kde5/include/KDE/KParts/WindowArgs
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131106/5808ae9b/attachment.html>


More information about the Kde-frameworks-devel mailing list