Review Request 113527: Move KPassivePopup to KNotifications and fix placement

[Alex Merry]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113527/
-----------------------------------------------------------

(Updated Nov. 6, 2013, 11:54 a.m.)


Review request for KDE Frameworks, Fredrik Höglund and Martin Gräßlin.


Changes
-------

Explicitly add our local X experts to the reviewers.


Repository: kdelibs


Description
-------

Alternative to RR 113393.

Commit 1: Move KPassivePopup to KNotifications

As well as being a conceptual fit, KPassivePopup needs to do X11 magic,
and this is a lot easier if it can make use of the KWindowSystem
library.


Commit 2: Fix KPassivePopup placement

The non-X11 code is largely untested.


Diffs
-----

  tier1/kwidgetsaddons/CMakeLists.txt 01bae90e235fae424f3af48fb95dc24286e60562 
  tier1/kwidgetsaddons/src/CMakeLists.txt beb5ecad9e063936dea9ca38f42238988ca3f51b 
  tier1/kwidgetsaddons/src/kpassivepopup.h d7cef3dd94713554010547001de6b4d81e3e2961 
  tier1/kwidgetsaddons/src/kpassivepopup.cpp 663f63af413b7660c9c1b21af3e3ae4d7c424bbe 
  tier1/kwidgetsaddons/tests/CMakeLists.txt d0140ea2489a629949b7022f310dcd6349c06f20 
  tier1/kwidgetsaddons/tests/kpassivepopuptest.h  
  tier1/kwidgetsaddons/tests/kpassivepopuptest.cpp 4e7138523bdbe4166bf0e899d39d9ae1f8b8b447 
  tier2/knotifications/src/CMakeLists.txt 7f5a332d6650f998d72c97b7cfddd27362756b08 
  tier2/knotifications/tests/CMakeLists.txt 6f3be50819ffef19644b77c397e5b4966d61abd6 
  tier4/kde4support/tests/CMakeLists.txt b22e2e818fc13519318fa32de44f5d4a32301661 

Diff: http://git.reviewboard.kde.org/r/113527/diff/


Testing
-------

Test app (in tests/ folder) works as expected on X11: if _NET_WM_ICON_GEOMETRY is set and a window id is passed, the popup is placed by the taskbar entry; if it is not set, it is place by the window; if a window id is not passed, it is placed top left (avoiding any panels) on the desktop.


Thanks,

Alex Merry

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131106/581359b1/attachment.html>