Review Request 113670: Link kde4support privately to QtX11Extras and QtSvg

[Alexander Richardson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113670/
-----------------------------------------------------------

Review request for KDE Frameworks.


Repository: kdelibs


Description
-------

Link kde4support privately to QtX11Extras and QtSvg

They are not needed in the API and are therefore an implemenation detail


Diffs
-----

  tier4/kde4support/src/kdeui/kxerrorhandler.cpp 3f4765d03559c99833c573fe0e0072bc9973b973 
  tier4/kde4support/src/kdeui/kxerrorhandler.h babf931e8a750d405885f02443f4910356511429 
  tier4/kde4support/src/CMakeLists.txt 6fc10d12f0e9ea0b8b89d2fcf289ca086a3a1b10 

Diff: http://git.reviewboard.kde.org/r/113670/diff/


Testing
-------

I previously got the following error compiling okteta, now it works:
/usr/lib64/gcc/x86_64-suse-linux/4.7/../../../../x86_64-suse-linux/bin/ld: cannot find -lQt5::X11Extras
/usr/lib64/gcc/x86_64-suse-linux/4.7/../../../../x86_64-suse-linux/bin/ld: cannot find -lQt5::Svg

QtX11Info and QtSvg are not used in any installed headers, so IMO this should be fine


Thanks,

Alexander Richardson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131106/d432fc31/attachment.html>