Review Request 113643: Fix Standalone Configuration for KJobWidgets

[David Narváez]

> On Nov. 5, 2013, 1:54 p.m., Aurélien Gâteau wrote:
> > tier2/kjobwidgets/src/CMakeLists.txt, line 17
> > <http://git.reviewboard.kde.org/r/113643/diff/1/?file=209153#file209153line17>
> >
> >     You should replace this line with:
> >     
> >     if("${CMAKE_BINARY_DIR}" STREQUAL "${CMAKE_CURRENT_BINARY_DIR}")
> >     
> >     This is more future-proof in case the top-level project gets renamed.
> 
> David Narváez wrote:
>     Mmm, I understand your point but note that
>     
>     CMAKE_BINARY_DIR /usr/local/src/kf5-standalone/kjobwidgets
>     CMAKE_CURRENT_BINARY_DIR /usr/local/src/kf5-standalone/kjobwidgets/src
>
> 
> Aleix Pol Gonzalez wrote:
>     You should always do the find_package() from the root CMakeLists.txt of the module.

Right, my bad, I'm uploading the fixed version of the patch.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113643/#review43058
-----------------------------------------------------------


On Nov. 5, 2013, 1:53 p.m., David Narváez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113643/
> -----------------------------------------------------------
> 
> (Updated Nov. 5, 2013, 1:53 p.m.)
> 
> 
> Review request for KDE Frameworks and Aurélien Gâteau.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> Specify required find_packages when not in kdelib's source dir. This does not fix the standalone build itself.
> 
> 
> Diffs
> -----
> 
>   tier2/kjobwidgets/src/CMakeLists.txt 032df16 
> 
> Diff: http://git.reviewboard.kde.org/r/113643/diff/
> 
> 
> Testing
> -------
> 
> 1. Configure a standalone build
> 
> Before this patch the configuration would complain of missing find_packages for KCore
> 
> 
> Thanks,
> 
> David Narváez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131105/02d7aaad/attachment.html>