Review Request 113634: Generate one autotest per each kdriwatch compiled bakend

Alexander Richardson arichardson.kde at googlemail.com
Tue Nov 5 12:32:27 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113634/#review43051
-----------------------------------------------------------



tier1/kcoreaddons/autotests/CMakeLists.txt
<http://git.reviewboard.kde.org/r/113634/#comment31051>

    Wouldn't it be possible to only compile the exectuable once and then add multiple tests in the loop:
    
    foreach(_backendName ${KDIRWATCH_BACKENDS_TO_TEST})
      add_test(kdirwatch_unittest_${_backendName} kdirwatch_unittest)
      set_tests_properties(kdirwatch_unittest_${_backendName} PROPERTIES ENVIRONMENT KDIRWATCH_METHOD=${_backendName})
    endforeach()
    
    Not sure if that works, but it would slightly reduce build time if it does.
    


- Alexander Richardson


On Nov. 5, 2013, 12:15 p.m., Àlex Fiestas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113634/
> -----------------------------------------------------------
> 
> (Updated Nov. 5, 2013, 12:15 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> KDirWatch can use different backends and we need to test them all, so
>     from now on we will be generating one test per each compiled backend.
> 
> 
> Diffs
> -----
> 
>   tier1/kcoreaddons/autotests/CMakeLists.txt bf7d1a1 
>   tier1/kcoreaddons/autotests/ConfigureChecks.cmake PRE-CREATION 
>   tier1/kcoreaddons/autotests/kdirwatch_unittest.cpp 585ff96 
> 
> Diff: http://git.reviewboard.kde.org/r/113634/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Àlex Fiestas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131105/733ba262/attachment.html>


More information about the Kde-frameworks-devel mailing list