Review Request 113516: Implement queueing directly in KDialogJobUiDelegate

[Àlex Fiestas]

> On Nov. 2, 2013, 1:42 p.m., Alex Merry wrote:
> > tier2/kjobwidgets/src/kdialogjobuidelegate.cpp, lines 73-76
> > <http://git.reviewboard.kde.org/r/113516/diff/1/?file=206575#file206575line73>
> >
> >     Would it not be marginally more efficient (and still correct) to put this test at the end of the method, with the invokeMethod in an else clause?

I'd prefer to keep it with the "Return early", makes the code easier to read.


- Àlex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113516/#review42831
-----------------------------------------------------------


On Oct. 31, 2013, 9:41 a.m., Àlex Fiestas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113516/
> -----------------------------------------------------------
> 
> (Updated Oct. 31, 2013, 9:41 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> Implement queueing directly in KDialogJobUiDelegate by queueing calls to KDialogJobUiDelegate::Private::next which shows 1 KMessageBox at the time.
> 
> 
> Diffs
> -----
> 
>   tier2/kjobwidgets/src/kdialogjobuidelegate.cpp 29c2bae 
>   tier2/kjobwidgets/tests/kjobtrackerstest.cpp 7a61407 
> 
> Diff: http://git.reviewboard.kde.org/r/113516/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Àlex Fiestas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131105/c3949a2d/attachment-0001.html>