Review Request 113500: make KNewStuff build on its own
Alex Merry
kde at randomguy3.me.uk
Tue Nov 5 10:16:31 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113500/#review43035
-----------------------------------------------------------
Ship it!
Looks good to me, other than the trailing spaces noted below.
tier3/knewstuff/CMakeLists.txt
<http://git.reviewboard.kde.org/r/113500/#comment31035>
Trailing spaces
- Alex Merry
On Nov. 4, 2013, 7:52 p.m., Jeremy Whiting wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113500/
> -----------------------------------------------------------
>
> (Updated Nov. 4, 2013, 7:52 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kdelibs
>
>
> Description
> -------
>
> With these changes, KNewStuff can build on it's own and as part of kdelibs.
>
>
> Diffs
> -----
>
> tier3/knewstuff/CMakeLists.txt 534ff2f5276591620fa0250d7d6971d75f572209
> tier3/knewstuff/src/CMakeLists.txt 24a601ab8df2465382d9114d47f6ff805a17a317
>
> Diff: http://git.reviewboard.kde.org/r/113500/diff/
>
>
> Testing
> -------
>
> Builds by itself and as part of kdelibs.
>
>
> Thanks,
>
> Jeremy Whiting
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131105/3269cdd0/attachment.html>
More information about the Kde-frameworks-devel
mailing list