Review Request 113625: Prepare KHTML for moving into tier4.

Martin Klapetek martin.klapetek at gmail.com
Mon Nov 4 19:29:55 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113625/#review42979
-----------------------------------------------------------



khtml/src/CMakeLists.txt
<http://git.reviewboard.kde.org/r/113625/#comment31025>

    Super-small-nitpick - this could be merged with the target_link_libraries above (the big one) as is the case with other frameworks, makes it more readable imho


- Martin Klapetek


On Nov. 4, 2013, 6:13 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113625/
> -----------------------------------------------------------
> 
> (Updated Nov. 4, 2013, 6:13 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> Tidy target_link for KHTML.
> 
> 
> Diffs
> -----
> 
>   khtml/src/CMakeLists.txt ed113f5 
>   khtml/src/java/CMakeLists.txt 3dd2d88 
> 
> Diff: http://git.reviewboard.kde.org/r/113625/diff/
> 
> 
> Testing
> -------
> 
> Builds.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131104/5b8ed4d9/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list