Review Request 113583: Fix build after enabling C++11 standard

Alexander Richardson arichardson.kde at googlemail.com
Sat Nov 2 18:33:39 UTC 2013



> On Nov. 2, 2013, 5:03 p.m., Christoph Feck wrote:
> > Oh wait... the function has been moved to the std:: namespace for C++11, so it would break on older compilers. Is there a standard way to check if we have a C++11 compiler?

How about using namespace std; inside that function? That should work in both cases


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113583/#review42837
-----------------------------------------------------------


On Nov. 2, 2013, 4:55 p.m., Christoph Feck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113583/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2013, 4:55 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> The standard says for C++ this is a function, I hope this is not a macro on some compilers...
> 
> 
> Diffs
> -----
> 
>   khtml/src/xpath/predicate.cpp 3180fe5 
> 
> Diff: http://git.reviewboard.kde.org/r/113583/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Christoph Feck
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131102/bff5be93/attachment.html>


More information about the Kde-frameworks-devel mailing list