Review Request 113578: Remove KTextEditSpellInterface

[Alex Merry]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113578/#review42835
-----------------------------------------------------------


Generally fine, apart from the comments.


tier3/ktextwidgets/src/widgets/ktextedit.cpp
<http://git.reviewboard.kde.org/r/113578/#comment30986>

    Your text editor's done something weird here: replaced a tab with 4 spaces and a tab.  It should either be replaced with 8 spaces or left alone.



tier3/ktextwidgets/src/widgets/ktextedit.cpp
<http://git.reviewboard.kde.org/r/113578/#comment30987>

    You appear to have flipped value of this conditional.


- Alex Merry


On Nov. 1, 2013, 11:28 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113578/
> -----------------------------------------------------------
> 
> (Updated Nov. 1, 2013, 11:28 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> Remove KTextEditSpellInterface.
> 
> 
> Diffs
> -----
> 
>   tier3/ktextwidgets/src/widgets/ktextedit.cpp b78096b 
>   tier3/ktextwidgets/src/widgets/ktextedit.h ff5ab8e 
> 
> Diff: http://git.reviewboard.kde.org/r/113578/diff/
> 
> 
> Testing
> -------
> 
> builds and tests pass.
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131102/425dd5e7/attachment-0001.html>