Review Request 113535: Fix build with latest ThreadWeaver

Commit Hook null at kde.org
Fri Nov 1 18:09:53 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113535/#review42792
-----------------------------------------------------------


This review has been submitted with commit f114f7310dd4af72813262a969a05d3daee115a2 by Christoph Feck to branch master.

- Commit Hook


On Nov. 1, 2013, 1:31 p.m., Christoph Feck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113535/
> -----------------------------------------------------------
> 
> (Updated Nov. 1, 2013, 1:31 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> With recent API updates in ThreadWeaver, "enqueueRaw()" was obsoleted. According to ThreadWeaver maintainers, the correct way to restart threads is to call "reschedule()", but I am not sure if my fix is correct, partly because the comment seems to be in the wrong place.
> 
> 
> Diffs
> -----
> 
>   src/plasma/private/runnerjobs_p.h dfc2aca 
>   src/plasma/runnermanager.cpp ee4851f 
> 
> Diff: http://git.reviewboard.kde.org/r/113535/diff/
> 
> 
> Testing
> -------
> 
> Compiles, no further testing.
> 
> 
> Thanks,
> 
> Christoph Feck
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131101/def1a3f7/attachment.html>


More information about the Kde-frameworks-devel mailing list