Review Request 113533: Adapt KCMInit to use DBus to communicate with KSplash

Àlex Fiestas afiestas at kde.org
Fri Nov 1 17:20:46 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113533/#review42775
-----------------------------------------------------------

Ship it!


Looks good!

- Àlex Fiestas


On Nov. 1, 2013, 12:55 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113533/
> -----------------------------------------------------------
> 
> (Updated Nov. 1, 2013, 12:55 p.m.)
> 
> 
> Review request for kde-workspace and KDE Frameworks.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> The xatom interface was removed from KSplash and replaced with a DBus one. This makes kcminit use the DBus interface and also removes the Xlib dependency (two commits).
> 
> 
> Diffs
> -----
> 
>   kcminit/main.cpp 856d8b7 
> 
> Diff: http://git.reviewboard.kde.org/r/113533/diff/
> 
> 
> Testing
> -------
> 
> KCMInit is still disabled for building, not much to test yet, but it works elsewhere, no reason to not work here.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131101/a1e258e8/attachment.html>


More information about the Kde-frameworks-devel mailing list