Review Request 113535: Fix build with latest ThreadWeaver
Christoph Feck
christoph at maxiom.de
Fri Nov 1 13:31:03 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113535/
-----------------------------------------------------------
(Updated Nov. 1, 2013, 1:31 p.m.)
Review request for KDE Frameworks and Plasma.
Changes
-------
DummyJob no longer needed.
Repository: plasma-framework
Description
-------
With recent API updates in ThreadWeaver, "enqueueRaw()" was obsoleted. According to ThreadWeaver maintainers, the correct way to restart threads is to call "reschedule()", but I am not sure if my fix is correct, partly because the comment seems to be in the wrong place.
Diffs (updated)
-----
src/plasma/private/runnerjobs_p.h dfc2aca
src/plasma/runnermanager.cpp ee4851f
Diff: http://git.reviewboard.kde.org/r/113535/diff/
Testing
-------
Compiles, no further testing.
Thanks,
Christoph Feck
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131101/6def203b/attachment.html>
More information about the Kde-frameworks-devel
mailing list