Review Request 110733: move kpixmapsequence, kpixmapsequenceoverlaypainter, kpixmapsequencewidget to KIconThemes

[Wojciech Kapuscinski]

> On May 30, 2013, 4:42 p.m., David Faure wrote:
> > staging/kiconthemes/src/kpixmapsequence.h, line 28
> > <http://git.reviewboard.kde.org/r/110733/diff/1/?file=147058#file147058line28>
> >
> >     AFAICS this include isn't needed, in the header file.

So I should comment KIconLoader::SizeSmall in constructor declaration and add default value to constructor definition?


- Wojciech


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110733/#review33450
-----------------------------------------------------------


On May 30, 2013, 4:33 p.m., Wojciech Kapuscinski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110733/
> -----------------------------------------------------------
> 
> (Updated May 30, 2013, 4:33 p.m.)
> 
> 
> Review request for KDE Frameworks, David Faure and Kevin Ottens.
> 
> 
> Description
> -------
> 
> move kpixmapsequence, kpixmapsequenceoverlaypainter, kpixmapsequencewidget to KIconThemes
> 
> Note: 
> port kWarning to qWarning
> removed unused #include <kdebug.h>
> 
> 
> Diffs
> -----
> 
>   kdeui/CMakeLists.txt d22f528 
>   kdeui/tests/CMakeLists.txt 881f8e5 
>   kdeui/tests/kpixmapsequenceoverlaypaintertest.h beb27d6 
>   kdeui/tests/kpixmapsequenceoverlaypaintertest.cpp 0275fc7 
>   kdeui/util/kpixmapsequence.h 5515fda 
>   kdeui/util/kpixmapsequence.cpp a31892f 
>   kdeui/util/kpixmapsequenceoverlaypainter.h 723ac93 
>   kdeui/util/kpixmapsequenceoverlaypainter.cpp c67a018 
>   kdeui/util/kpixmapsequencewidget.h 17c5be2 
>   kdeui/util/kpixmapsequencewidget.cpp 37c4918 
>   staging/kiconthemes/src/CMakeLists.txt 49e6b92 
>   staging/kiconthemes/src/kpixmapsequence.h PRE-CREATION 
>   staging/kiconthemes/src/kpixmapsequence.cpp PRE-CREATION 
>   staging/kiconthemes/src/kpixmapsequenceoverlaypainter.h PRE-CREATION 
>   staging/kiconthemes/src/kpixmapsequenceoverlaypainter.cpp PRE-CREATION 
>   staging/kiconthemes/src/kpixmapsequencewidget.h PRE-CREATION 
>   staging/kiconthemes/src/kpixmapsequencewidget.cpp PRE-CREATION 
>   staging/kiconthemes/tests/CMakeLists.txt 06e9b57 
>   staging/kiconthemes/tests/kpixmapsequenceoverlaypaintertest.h PRE-CREATION 
>   staging/kiconthemes/tests/kpixmapsequenceoverlaypaintertest.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/110733/diff/
> 
> 
> Testing
> -------
> 
> Build tested
> 
> 
> Thanks,
> 
> Wojciech Kapuscinski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130530/72f6183f/attachment-0001.html>