Review Request 110622: Move KDateWidget to KDE4Attic

David Faure faure at kde.org
Tue May 28 14:16:13 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110622/#review33067
-----------------------------------------------------------



staging/kde4attic/tests/kdatewidgettest.cpp
<http://git.reviewboard.kde.org/r/110622/#comment24451>

    unused



staging/kde4attic/tests/kdatewidgettest.cpp
<http://git.reviewboard.kde.org/r/110622/#comment24449>

    kaboutdata isn't used (anymore), you can remove the include.



staging/kde4attic/tests/kdatewidgettest.cpp
<http://git.reviewboard.kde.org/r/110622/#comment24450>

    not used either


- David Faure


On May 23, 2013, 7:29 p.m., Anne-Marie Mahfouf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110622/
> -----------------------------------------------------------
> 
> (Updated May 23, 2013, 7:29 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Description
> -------
> 
> Move ktimewidget.{h,cpp} to kde4attic/src/
> Move kdatewidgettest.cpp to kde4attic/tests/
> Amend the CMakeLists.txt accordingly
> Change export in kdatewidget.h
> 
> 
> Diffs
> -----
> 
>   kdeui/CMakeLists.txt dcbcb4f 
>   kdeui/tests/CMakeLists.txt c9401cb 
>   kdeui/tests/kdatewidgettest.cpp 76af7cf 
>   kdeui/widgets/kdatewidget.h e955338 
>   kdeui/widgets/kdatewidget.cpp 2e0572d 
>   staging/kde4attic/src/CMakeLists.txt 7a82d62 
>   staging/kde4attic/src/kdatewidget.h PRE-CREATION 
>   staging/kde4attic/src/kdatewidget.cpp PRE-CREATION 
>   staging/kde4attic/tests/CMakeLists.txt d72f14d 
>   staging/kde4attic/tests/kdatewidgettest.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/110622/diff/
> 
> 
> Testing
> -------
> 
> Frameworks builds
> 
> 
> Thanks,
> 
> Anne-Marie Mahfouf
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130528/eb5ca46e/attachment.html>


More information about the Kde-frameworks-devel mailing list