Review Request 110643: Move KPasswordDialog to tier1/kwidgetaddons

[David Edmundson]

> On May 25, 2013, 5:17 p.m., David Gil Oliva wrote:
> > kdeui/dialogs/kpassworddialog.cpp, line 346
> > <http://git.reviewboard.kde.org/r/110643/diff/1/?file=146196#file146196line346>
> >
> >     Sometimes there are spaces around parentheses, sometimes there is only one space and sometimes there's none. Style should be uniform. What's the preferred? (Mine is no spaces)
> 
> David Edmundson wrote:
>     My preference is no spaces too, but I tried to follow the style already in this file which seemed to have spaces
> 
> David Faure wrote:
>     This isn't about personal preference, however :)
>     
>     When touching lines of code for other reasons, please adapt them to the kdelibs coding style. Which is indeed no spaces inside parenthesis. http://techbase.kde.org/Policies/Kdelibs_Coding_Style

To clarify in simple terms for me.

When we modify a file for frameworks porting should we copy the style already used, use kdelibs coding style on lines we edit, or adjust the whole thing?


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110643/#review33132
-----------------------------------------------------------


On May 25, 2013, 12:57 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110643/
> -----------------------------------------------------------
> 
> (Updated May 25, 2013, 12:57 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Known "bugs"
>  - there's no clear icon in the text field anymore as I had to port away from KLineEdit
> 
> Diff shown is without the actual moving for easier reviewing.
> 
> 
> Diffs
> -----
> 
>   kdeui/CMakeLists.txt cfa29ef 
>   kdeui/dialogs/kpassworddialog.h e554c2a 
>   kdeui/dialogs/kpassworddialog.cpp 168271c 
>   kdeui/dialogs/kpassworddialog.ui 95845b9 
>   kdeui/tests/CMakeLists.txt cd055d5 
>   kdeui/tests/kpassworddialogtest.cpp b1c55ee 
>   tier1/kwidgetsaddons/src/CMakeLists.txt df22699 
>   tier1/kwidgetsaddons/tests/CMakeLists.txt de5e6e4 
> 
> Diff: http://git.reviewboard.kde.org/r/110643/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130527/8c2fb07b/attachment.html>