make test failures

[David Faure]

On Thursday 23 May 2013 20:43:39 Alexander Neundorf wrote:
> On Thursday 23 May 2013, David Faure wrote:
> > On Thursday 23 May 2013 09:53:53 Kurt Hindenburg wrote:
> > > Hello, I'm running a VM built from lubuntu with no Qt4/KDE4 installed.
> > > 
> > > One change I had to make was to the plugin variable to add the
> > > i386-linux-gnu part.
> 
> which plugin variable ?

QT_PLUGIN_PATH

> > > /home/kurthindenburg/kf5/kde_frameworks/lib/i386-linux-gnu/plugins:/home
> > > /kurthindenburg/kf5/qt5/plugins:
> > Alex or Steve? This weird LIB_INSTALL_DIR value seems to come from
> > GNUInstallDirs? There's a comment about multiarch in there, so I suppose
> > it's expected...
> 
> Yes, lib/i386-linux-gnu/ looks good if it is a debian multiarch system.

For both libs and plugins, I assume.

But clearly it breaks somewhere :)

Hmm, probably there, actually:
kde4support/src/kdecore/kstandarddirs.cpp: 290:                 return QFile::decodeName("lib" KDELIBSUFF "/kde5/libexec/");

Kurt, can you try this?

diff --git a/staging/kde4support/src/kdecore/kstandarddirs.cpp b/staging/kde4support/src/kdecore/kstandarddirs.cpp
index 4bf61d1..ed8fea3 100644
--- a/staging/kde4support/src/kdecore/kstandarddirs.cpp
+++ b/staging/kde4support/src/kdecore/kstandarddirs.cpp
@@ -287,7 +287,7 @@ static QString relativeInstallPath(const char *type)
             if (strcmp("lib", type) == 0)
                 return QFile::decodeName(LIB_INSTALL_DIR "/");
             if (strcmp("libexec", type) == 0)
-                return QFile::decodeName("lib" KDELIBSUFF "/kde5/libexec/");
+                return QFile::decodeName(LIB_INSTALL_DIR "/kde5/libexec/");
             if (strcmp("locale", type) == 0)
                 return QFile::decodeName(LOCALE_INSTALL_DIR "/");
             break;
@@ -1872,7 +1872,7 @@ void KStandardDirs::addKDEDefaults()
     // end XDG_DATA_XXX
 
 
-    addResourceType("lib", 0, "lib" KDELIBSUFF "/");
+    addResourceType("lib", 0, LIB_INSTALL_DIR "/");
 
     addResourceType("qtplugins", "lib", "plugins");
 



-- 
David Faure, faure at kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5