Review Request 108845: add support for SSSE3 and SSE4.2 in cpufeatures and for msvc

Kevin Ottens ervin at kde.org
Thu May 23 11:02:27 UTC 2013



> On May 6, 2013, 11:49 a.m., Kevin Ottens wrote:
> > My knowledge of the changes in the MMX/SSE landscape are slightly too limited for me to be 100% sure. But it looks like a fine patch.
> 
> Patrick Spendrin wrote:
>     I just at that patch again, and I just realized that I changed the flags for Linux too, so it might change some stuff there too. Did you actually look at this stuff, and can you check if this gives you SSE4.2 e.g. (probably on your computer available).

Works here, I indeed get 4.2 reported.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108845/#review32127
-----------------------------------------------------------


On May 22, 2013, 3:31 p.m., Patrick Spendrin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108845/
> -----------------------------------------------------------
> 
> (Updated May 22, 2013, 3:31 p.m.)
> 
> 
> Review request for KDE Frameworks, kdelibs and Patrick von Reth.
> 
> 
> Description
> -------
> 
> This change implements cpu feature checks for MSVC. While at it, I added support SSSE3 and SSE4.2 to the InstructionSets. I took the new values from http://en.wikipedia.org/wiki/CPUID#EAX.3D1:_Processor_Info_and_Feature_Bits .
> 
> 
> Diffs
> -----
> 
>   tier1/solid/src/solid/processor.h ce4f0e1 
>   tier1/solid/src/solid/backends/shared/cpufeatures.cpp baa1af2 
> 
> Diff: http://git.reviewboard.kde.org/r/108845/diff/
> 
> 
> Testing
> -------
> 
> Windows
> 
> 
> Thanks,
> 
> Patrick Spendrin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130523/b08fc9b0/attachment.html>


More information about the Kde-frameworks-devel mailing list