Review Request 110482: Move KStatusNotifierItem in KNotifications

[Kevin Ottens]

> On May 21, 2013, 10:46 a.m., Kevin Ottens wrote:
> > I think it's taking the right direction. Probably good to get rid of ki18n if we don't use any of its advanced features (I don't think we do). As for kwidgets and kwidgetsaddons, it depends a bit on the aim we have for that library and which tier we want for it. If we aim tier1 it can't depend on them, if we aim tier2 it can depend on kwidgetsaddons, if we aim tier3 it can depend on both.
> > 
> > Any idea why it requires KWidgets and KWidgetsAddons?
> > 
> > Test should be streamlined to bring less dependencies too.
> 
> Marco Martin wrote:
>     i think kwidgets and kwidgetsaddons are required by the "are sure you want to quit" dialog, shar should be rebuilt using only basic qt stuff.
>     
>     another source of dependencies is the small test app, that uses kcmdlineargs and kiconloader for "findMovie"
> 
> Marco Martin wrote:
>     ah, in general, what should replace KActionCollections?

Well, there's no real replacement for KActionCollection, it's here to stay, but will be in XMLGUI which is a high tier framework. Going for a QHash as you did is likely a good thing for the status notifier, it doesn't need XMLGUI per say... Maybe we'll need conversion convenience to and from KActionCollection in XMLGUI though.

KCmdLineArgs can be replaced with QCommandLineParser (part of kdeqt5staging until it's in Qt itself).


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110482/#review32879
-----------------------------------------------------------


On May 21, 2013, 12:45 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110482/
> -----------------------------------------------------------
> 
> (Updated May 21, 2013, 12:45 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> This implemets a step in the kdeui crumble epic.
> 
> moves the classes kstatusnotifieritem and knotificationsrestrictions in the knotifiactions library.
> 
> The patch works, but there are still several issues:
> * porting from kdebug to qdebug loses the area number
> * adds some link libraries: the classes add ki18n, kwidgets and KWidgetsAddons
> * the test adds ki18n kde4support kdecore
> * the KActionCollection becomes a qhash of actions: how should be kactioncollections ported?
> 
> I guess it should use the qt translation system, and redo the quit dialog to not usekstandardgui at all?
> 
> 
> Diffs
> -----
> 
>   kdeui/CMakeLists.txt cfa29ef 
>   kdeui/notifications/knotificationrestrictions.h 7b83d25 
>   kdeui/notifications/knotificationrestrictions.cpp a396fd6 
>   kdeui/notifications/kstatusnotifieritem.h be21882 
>   kdeui/notifications/kstatusnotifieritem.cpp 37abe7e 
>   kdeui/notifications/kstatusnotifieritemdbus_p.h 063343c 
>   kdeui/notifications/kstatusnotifieritemdbus_p.cpp 6c9e1da 
>   kdeui/notifications/kstatusnotifieritemprivate_p.h 32e7906 
>   kdeui/notifications/org.freedesktop.Notifications.xml 8ddb421 
>   kdeui/notifications/org.kde.StatusNotifierItem.xml 82c427d 
>   kdeui/notifications/org.kde.StatusNotifierWatcher.xml dd45dc9 
>   kdeui/tests/CMakeLists.txt cd055d5 
>   kdeui/tests/kstatusnotifieritemtest.h 38a1e1a 
>   kdeui/tests/kstatusnotifieritemtest.cpp 38e85ac 
>   staging/knotifications/src/CMakeLists.txt 266b67c 
>   staging/knotifications/src/config-knotifications.h.cmake PRE-CREATION 
>   staging/knotifications/tests/CMakeLists.txt 2240a69 
> 
> Diff: http://git.reviewboard.kde.org/r/110482/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130521/3d9294c2/attachment.html>