Review Request 110540: Move KAccelGen and kaccelgentest to KDE4Support

[Kevin Ottens]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110540/#review32878
-----------------------------------------------------------

Ship it!


Ship It!

- Kevin Ottens


On May 20, 2013, 10:40 a.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110540/
> -----------------------------------------------------------
> 
> (Updated May 20, 2013, 10:40 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Move KAccelGen and kaccelgentest to KDE4Support
> 
> Not used anywhere else in kdelibs.
> 
> I didn't put a porting comment into the apidocs, because (a) I wasn't entirely certain what the porting strategy should be, and (b) lxr.kde.org suggests that in practice "don't be konqueror" is a good porting strategy.
> 
> 
> Diffs
> -----
> 
>   kdeui/CMakeLists.txt cfa29ef 
>   kdeui/tests/CMakeLists.txt cd055d5 
>   kdeui/tests/kaccelgentest.cpp 24afd07 
>   kdeui/util/kaccelgen.h a7decd7 
>   staging/kde4support/autotests/CMakeLists.txt b61c8f3 
>   staging/kde4support/autotests/kaccelgentest.cpp PRE-CREATION 
>   staging/kde4support/src/CMakeLists.txt a8e0a0c 
>   staging/kde4support/src/kdeui/kaccelgen.h PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/110540/diff/
> 
> 
> Testing
> -------
> 
> Still builds, tests still run (and the same ones seem to pass as before, including kaccelgentest).
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130521/41563a3d/attachment-0001.html>