Simplifying KConfigDialogManager

Kevin Ottens ervin+bluesystems at kde.org
Tue May 21 05:25:35 UTC 2013


On Thursday 16 May 2013 08:13:55 David Edmundson wrote:
> KConfigDialogManager currently contains a map of every possible widget
> along with the name of the signal to connect to to know when a widget
> changes.
> 
> Can we kill this entire map and replace it with monitoring
> widget->metaObject()->userProperty()->notifySignal() at runtime?
> It will greatly simplify the code in there, whilst also making it more
> extensible/flexible/future proof.

I'm not sure I understand what you are after. userProperty() is already used 
at some places (ok, not its notifySignal()). As Albert mention even if we use 
it more (likely a good thing as you point out), we'd still need the map as 
we're not always monitoring the user property (most notably for QComboBox 
indeed).

So I agree a patch would be interesting, I doubt we can completely remove that 
map though. :-)

Regards.
-- 
Kévin Ottens, http://ervin.ipsquad.net

Sponsored by BlueSystems and KDAB to work on KDE Frameworks
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130521/c4f462ad/attachment.sig>


More information about the Kde-frameworks-devel mailing list