Review Request 110460: Move KTabBar to kde4support
Kevin Ottens
ervin at kde.org
Thu May 16 06:29:26 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110460/#review32630
-----------------------------------------------------------
Looks like there's a problem with the patch, I don't see both ends of the move (the deletes and adds are not displayed). Could you please rebase and upload a more complete patch? Thanks.
- Kevin Ottens
On May 15, 2013, 10:52 p.m., Alex Merry wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110460/
> -----------------------------------------------------------
>
> (Updated May 15, 2013, 10:52 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Description
> -------
>
> Move KTabBar to kde4support
>
> Nothing in kdelibs/frameworks seems to use it (other than KTabWidget, which is already in KDE4Support), so no disentangling to do.
>
>
> Diffs
> -----
>
> kdeui/CMakeLists.txt b439e04ee0c11f6ec072ca975fbb60f4973d29fd
> kdeui/widgets/ktabbar.h 94a5cc68c03ec17f8b0461cba11eca49a5c0e4c4
> kdeui/widgets/ktabbar.cpp cda64479d67d369a6d9764a535d8012922193d57
> staging/kde4support/src/CMakeLists.txt PRE-CREATION
>
> Diff: http://git.reviewboard.kde.org/r/110460/diff/
>
>
> Testing
> -------
>
> frameworks still builds.
>
>
> Thanks,
>
> Alex Merry
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130516/1bbba7b8/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list