Review Request 110456: KFontComboBox -> QFontComboBox

[Kevin Ottens]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110456/#review32629
-----------------------------------------------------------



kdeui/dialogs/kconfigdialogmanager.cpp
<http://git.reviewboard.kde.org/r/110456/#comment24273>

    Please keep KFontComboBox here for legacy code. It's done via introspection so it won't harm on the dependency side, and KFontComboBox doesn't have QFontComboBox as base class.



kdewidgets/kde.widgets
<http://git.reviewboard.kde.org/r/110456/#comment24274>

    This block should then reappear in kdedeprecated.widgets


- Kevin Ottens


On May 15, 2013, 5:35 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110456/
> -----------------------------------------------------------
> 
> (Updated May 15, 2013, 5:35 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> KFontComboBox -> QFontComboBox
> 
> 
> Diffs
> -----
> 
>   kdeui/dialogs/kconfigdialogmanager.cpp 620f0b5 
>   kdeui/widgets/kcharselect.cpp 2e43d0d 
>   kdewidgets/kde.widgets 6ccdcb65 
> 
> Diff: http://git.reviewboard.kde.org/r/110456/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130516/08a6a842/attachment.html>