Review Request 110415: Move kdatetimeedit to kde4attic

Kevin Ottens ervin at kde.org
Tue May 14 11:56:48 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110415/#review32493
-----------------------------------------------------------



staging/kde4attic/src/kdatetimeedit.h
<http://git.reviewboard.kde.org/r/110415/#comment24168>

    You need to change that to kde4attic_export.h



staging/kde4attic/src/kdatetimeedit.h
<http://git.reviewboard.kde.org/r/110415/#comment24169>

    Here it should be KDE4ATTIC_EXPORT


- Kevin Ottens


On May 14, 2013, 11:41 a.m., wojtas k9 wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110415/
> -----------------------------------------------------------
> 
> (Updated May 14, 2013, 11:41 a.m.)
> 
> 
> Review request for KDE Frameworks, David Faure and Kevin Ottens.
> 
> 
> Description
> -------
> 
> Move kdatetimeedit to kde4attic
> 
> 
> Diffs
> -----
> 
>   kdeui/CMakeLists.txt 3e18c2a 
>   kdeui/tests/CMakeLists.txt 69be059 
>   kdeui/tests/kdatetimeedittest.h 345df26 
>   kdeui/tests/kdatetimeedittest.cpp 258fd86 
>   kdeui/widgets/kdatetimeedit.h 6869f6e 
>   kdeui/widgets/kdatetimeedit.cpp 17b8a7d 
>   kdeui/widgets/kdatetimeedit.ui 6ac2290 
>   kdewidgets/CMakeLists.txt 284b4e7 
>   staging/kde4attic/src/CMakeLists.txt 63377b8 
>   staging/kde4attic/src/kdatetimeedit.h PRE-CREATION 
>   staging/kde4attic/src/kdatetimeedit.cpp PRE-CREATION 
>   staging/kde4attic/src/kdatetimeedit.ui PRE-CREATION 
>   staging/kde4attic/tests/CMakeLists.txt ae63907 
>   staging/kde4attic/tests/kdatetimeedittest.h PRE-CREATION 
>   staging/kde4attic/tests/kdatetimeedittest.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/110415/diff/
> 
> 
> Testing
> -------
> 
> It builds.
> 
> 
> Thanks,
> 
> wojtas k9
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130514/52b59482/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list