Review Request 110351: Move KFontDialog to KDE4Suport

Anne-Marie Mahfouf annma at kde.org
Wed May 8 11:46:01 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110351/
-----------------------------------------------------------

(Updated May 8, 2013, 11:46 a.m.)


Review request for KDE Frameworks, David Faure and Kevin Ottens.


Changes
-------

This diff makes the move of KFontDialog to KDE4Support and is unchanged from the first one, the first one was splitted in 2.


Description
-------

Move KFontDialog to KDE4Support, move test as well, thing to check is diff for kdeui/fonts/kfontrequester.cpp to see if I got it right.


Diffs (updated)
-----

  kdeui/CMakeLists.txt 38a7238 
  kdeui/fonts/kfontdialog.h 9098a83 
  kdeui/fonts/kfontdialog.cpp 8632183 
  kdeui/tests/CMakeLists.txt 037cec1 
  kdeui/tests/kfontdialogtest.cpp cbccadc 
  staging/kde4support/src/CMakeLists.txt f5fbe60 
  staging/kde4support/src/kdeui/kfontdialog.h PRE-CREATION 
  staging/kde4support/src/kdeui/kfontdialog.cpp PRE-CREATION 
  staging/kde4support/tests/CMakeLists.txt 3d6a6dd 
  staging/kde4support/tests/kfontdialogtest.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/110351/diff/


Testing
-------

It builds.


Thanks,

Anne-Marie Mahfouf

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130508/bc286a2c/attachment.html>


More information about the Kde-frameworks-devel mailing list