Review Request 110209: macro_add_file_dependencies -> set_property in tier2/kconfig

Commit Hook null at kde.org
Mon May 6 21:05:28 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110209/
-----------------------------------------------------------

(Updated May 6, 2013, 9:05 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and David Faure.


Description
-------

macro_add_file_dependencies -> set_property

Change from macro_add_file_dependencies to set_property as advised by the
macro_add_file_dependencies code comments in current cmake git.

I was getting errors from cmake about macro_add_file_dependencies not being found, and when I located the file with it in, it said that it was deprecated anyway, and to replace with set_property.


Diffs
-----

  tier2/kconfig/autotests/kconfig_compiler/CMakeLists.txt 87c7caa433e2916bebd0cab55f0489a3461e8208 

Diff: http://git.reviewboard.kde.org/r/110209/diff/


Testing
-------

Compiles fine now.


Thanks,

George Goldberg

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130506/bcfcfaf3/attachment.html>


More information about the Kde-frameworks-devel mailing list