Review Request 108845: add support for SSSE3 and SSE4.2 in cpufeatures and for msvc

Kevin Ottens ervin at kde.org
Mon May 6 11:49:30 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108845/#review32127
-----------------------------------------------------------

Ship it!


My knowledge of the changes in the MMX/SSE landscape are slightly too limited for me to be 100% sure. But it looks like a fine patch.

- Kevin Ottens


On Feb. 8, 2013, 1:09 a.m., Patrick Spendrin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108845/
> -----------------------------------------------------------
> 
> (Updated Feb. 8, 2013, 1:09 a.m.)
> 
> 
> Review request for KDE Frameworks, kdelibs and Patrick von Reth.
> 
> 
> Description
> -------
> 
> This change implements cpu feature checks for MSVC. While at it, I added support SSSE3 and SSE4.2 to the InstructionSets. I took the new values from http://en.wikipedia.org/wiki/CPUID#EAX.3D1:_Processor_Info_and_Feature_Bits .
> 
> 
> Diffs
> -----
> 
>   tier1/solid/src/solid/backends/shared/cpufeatures.cpp baa1af2 
>   tier1/solid/src/solid/processor.h ce4f0e1 
> 
> Diff: http://git.reviewboard.kde.org/r/108845/diff/
> 
> 
> Testing
> -------
> 
> Windows
> 
> 
> Thanks,
> 
> Patrick Spendrin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130506/9cc99f3a/attachment.html>


More information about the Kde-frameworks-devel mailing list