Review Request 109517: Port away from KListWidget to QListWidget

Martin Klapetek martin.klapetek at gmail.com
Sun Mar 24 20:07:37 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109517/
-----------------------------------------------------------

(Updated March 24, 2013, 8:07 p.m.)


Review request for KDE Frameworks.


Changes
-------

Sorry about the delay, I was afk the couple past days. Here's updated patch using itemActivated(..) instead of executed(..). The other KListWidget signal, doubleClicked(..), is nowhere used.

I'll have a look into the autoselect; should this patch be blocked until the autoselect is done in Qt?


Description
-------

Move KListWidget to kde4support and replace uses with QListWidget


Diffs (updated)
-----

  kdeui/CMakeLists.txt 03b1e8d 
  kdeui/dialogs/kinputdialog.cpp 28ce074 
  kdeui/dialogs/kinputdialog_p.h 9b40158 
  kdeui/fonts/kfontchooser.cpp a445f43 
  kdeui/icons/kicondialog.cpp aeba58c 
  kdeui/icons/kicondialog_p.h bc46295 
  kdeui/itemviews/klistwidget.h 48ef4d7 
  kdeui/itemviews/klistwidget.cpp 185db8b 
  kdeui/widgets/kcompletionbox.h 1dabb1a 
  kdeui/widgets/kcompletionbox.cpp a470621 
  khtml/rendering/render_form.h 28c3082 
  khtml/rendering/render_form.cpp 851a4dd 

Diff: http://git.reviewboard.kde.org/r/109517/diff/


Testing
-------

Compiles


Thanks,

Martin Klapetek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130324/33dd62ab/attachment.html>


More information about the Kde-frameworks-devel mailing list