Review Request 109551: port KPtyProcess to QProcess

[Oswald Buddenhagen]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109551/#review29802
-----------------------------------------------------------


after extensive deliberation of the code i found that ... i have no clue what is wrong.
you'll need to find out yourself (with strace -f -tt).

one notable difference between kprocess and qprocess is that the output channel mode default differs (kprocess forwards, while qprocess collects). however, i wasn't able to come up with an obvious explanation how that would correlate with your hangs.

- Oswald Buddenhagen


On March 18, 2013, 7:54 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109551/
> -----------------------------------------------------------
> 
> (Updated March 18, 2013, 7:54 p.m.)
> 
> 
> Review request for KDE Frameworks, kdelibs, David Faure, and Oswald Buddenhagen.
> 
> 
> Description
> -------
> 
> Just a simple port of KPtyProcess away from using KProcess.
> 
> 
> Diffs
> -----
> 
>   kpty/kptyprocess.h 5e0df96 
>   kpty/kptyprocess.cpp 015a58c 
>   kpty/tests/kptyprocesstest.cpp 04990a0 
> 
> Diff: http://git.reviewboard.kde.org/r/109551/diff/
> 
> 
> Testing
> -------
> 
> builds and tests pass.
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130324/f045e71e/attachment.html>