Review Request 109480: Add support for xcb_generic_event_t to KKeyServer::xEventToQt

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109480/#review29752
-----------------------------------------------------------



kdeui/util/kkeyserver_x11.h
<http://git.reviewboard.kde.org/r/109480/#comment22142>

    Maybe call it xcbKeyEventToQt, to avoid any ambiguity with the other xEventToQt method?
    Makes searching via lxr easier, too...


- David Faure


On March 14, 2013, 11:10 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109480/
> -----------------------------------------------------------
> 
> (Updated March 14, 2013, 11:10 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Allows converting an xcb key event to Qt key + modifier code just like
> the existing code for a XEvent. Slight difference: instead of an assert
> the method returns false in case it's not a key event.
> 
> 
> Diffs
> -----
> 
>   kdeui/CMakeLists.txt 03b1e8d 
>   kdeui/util/kkeyserver_x11.h 1b28815 
>   kdeui/util/kkeyserver_x11.cpp 4f74821 
> 
> Diff: http://git.reviewboard.kde.org/r/109480/diff/
> 
> 
> Testing
> -------
> 
> it compiles :-) I'm currently lacking ideas how to unit test it. If I don't find a solution I will notice once I'm running KWin on top of KF5
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130323/c320e374/attachment.html>