Review Request 109551: port KPtyProcess to QProcess

[Martin Tobias Holmedahl Sandsmark]

> On March 18, 2013, 10:04 p.m., Oswald Buddenhagen wrote:
> > kpty/tests/kptyprocesstest.cpp, line 193
> > <http://git.reviewboard.kde.org/r/109551/diff/2/?file=120310#file120310line193>
> >
> >     i don't think eating the sleep is a good idea. i'm sure i added it for a reason (in a previous life ^^).

with the sleep the test fails, and even with high load I can't get the test to fail without it.


> On March 18, 2013, 10:04 p.m., Oswald Buddenhagen wrote:
> > kpty/tests/kptyprocesstest.cpp, line 208
> > <http://git.reviewboard.kde.org/r/109551/diff/2/?file=120310#file120310line208>
> >
> >     because it's completely broken ^^

having looked at QProcess and KProcess and KPtyDevice I still don't understand what is broken...


> On March 18, 2013, 10:04 p.m., Oswald Buddenhagen wrote:
> > kpty/tests/kptyprocesstest.cpp, line 210
> > <http://git.reviewboard.kde.org/r/109551/diff/2/?file=120310#file120310line210>
> >
> >     the -c needs to be a separate argument.
> >     
> >     the quotes, backslashes and attempt at a newline are all garbage.

I first had -c as a separate argument, and it didn't matter. And I had to add an extra newline to get it to work with doing it manually.


- Martin Tobias Holmedahl


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109551/#review29478
-----------------------------------------------------------


On March 18, 2013, 7:54 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109551/
> -----------------------------------------------------------
> 
> (Updated March 18, 2013, 7:54 p.m.)
> 
> 
> Review request for KDE Frameworks, kdelibs, David Faure, and Oswald Buddenhagen.
> 
> 
> Description
> -------
> 
> Just a simple port of KPtyProcess away from using KProcess.
> 
> 
> Diffs
> -----
> 
>   kpty/kptyprocess.h 5e0df96 
>   kpty/kptyprocess.cpp 015a58c 
>   kpty/tests/kptyprocesstest.cpp 04990a0 
> 
> Diff: http://git.reviewboard.kde.org/r/109551/diff/
> 
> 
> Testing
> -------
> 
> builds and tests pass.
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130318/ac03905f/attachment-0001.html>