Review Request 109549: port KRun away from KProcess
Kevin Ottens
ervin at kde.org
Mon Mar 18 10:05:22 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109549/#review29429
-----------------------------------------------------------
Ship it!
Looks good to me provided you fixed the trailing whitespace issue mentionned previously.
- Kevin Ottens
On March 17, 2013, 4:19 p.m., Martin Tobias Holmedahl Sandsmark wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109549/
> -----------------------------------------------------------
>
> (Updated March 17, 2013, 4:19 p.m.)
>
>
> Review request for KDE Frameworks, kdelibs and David Faure.
>
>
> Description
> -------
>
> Port KRun to use QProcess instead of KProcess.
>
> Instead of passing around KProcess instances, we simply pass the command with arguments and the working directory.
>
>
> Diffs
> -----
>
> kio/kio/krun.cpp 76b7385
> kio/kio/krun_p.h 01abb69
>
> Diff: http://git.reviewboard.kde.org/r/109549/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Martin Tobias Holmedahl Sandsmark
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130318/9d1c140d/attachment.html>
More information about the Kde-frameworks-devel
mailing list