Review Request 109526: Implement SH_Widget_Animate in KStyle

[Kevin Ottens]

> On March 18, 2013, 9:57 a.m., Kevin Ottens wrote:
> > Looks good, can become a "shit it" once the patch in Qt his qt5.git.

Ahem... s/shit/ship/ obviously. Now that was an "interesting" typo, I think I'll have to consult a shrink for finding a reason for that one. :-)


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109526/#review29426
-----------------------------------------------------------


On March 16, 2013, 6:41 p.m., Àlex Fiestas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109526/
> -----------------------------------------------------------
> 
> (Updated March 16, 2013, 6:41 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Implement SH_Widget_Animate in KStyle using the configuration we already have in kdeglobal.
> 
> I have NOT implemented detailed information about animations because after all this year only NoEffect and SimpleAnimation are used (kglobalsettings.cpp GraphicEffect), so what we want is a YES or NO instead of how much animation is required.
> 
> There is NO use of GradientEffects or ComplexAnimationEffects in all kdelibs or kde (grepped 204 repositories in KDE)
> 
> Review depends on:
> https://codereview.qt-project.org/#change,51166
> 
> 
> Diffs
> -----
> 
>   kdeui/kernel/kstyle.cpp 681b940 
> 
> Diff: http://git.reviewboard.kde.org/r/109526/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Àlex Fiestas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130318/d12627ea/attachment.html>