Review Request 109531: Port the Sonnet ASpell plugin to the new style APIs

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109531/#review29362
-----------------------------------------------------------


Looks ok to me. Just two questions.


staging/sonnet/src/core/client_p.h
<http://git.reviewboard.kde.org/r/109531/#comment21946>

    Is this used anywhere? Funnily enough, the qobject_cast<Client *> in loadPlugin already compiles.
    Ah I see, that's because Client is a QObject, but it wouldn't need to be, with the interface stuff.



staging/sonnet/src/plugins/aspell/kspell_aspellclient.cpp
<http://git.reviewboard.kde.org/r/109531/#comment21945>

    Doesn't the .json file need to exist?
    Alternatively I think the FILE argument can be empty, iirc.


- David Faure


On March 16, 2013, 11:16 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109531/
> -----------------------------------------------------------
> 
> (Updated March 16, 2013, 11:16 p.m.)
> 
> 
> Review request for KDE Frameworks and kdelibs.
> 
> 
> Description
> -------
> 
> Port the ASpell plugin to the new style of doing plugins in Qt5.
> 
> I'll do the rest of the plugins afterwards if this looks okay.
> 
> 
> Diffs
> -----
> 
>   staging/sonnet/src/core/client_p.h cd5c0f2 
>   staging/sonnet/src/plugins/aspell/kspell_aspellclient.h 95173ff 
>   staging/sonnet/src/plugins/aspell/kspell_aspellclient.cpp b649d0d 
> 
> Diff: http://git.reviewboard.kde.org/r/109531/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130317/2b8821ff/attachment-0001.html>