Review Request 109519: Use QUrl::errorString() instead of QUrl::toString() in QMessageBox; adds qWarning as well

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109519/#review29320
-----------------------------------------------------------


One issue, rest looks good.


kio/kio/kdirlister.cpp
<http://git.reviewboard.kde.org/r/109519/#comment21913>

    This change is incorrect. The URL is valid at this point, but it uses a protocol that doesn't support listing (e.g. HTTP). Showing the URL with toString() was correct.
    
    The idea is to only fix the cases where !url.isValid(), since in that case toString() is empty.


- David Faure


On March 16, 2013, 12:42 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109519/
> -----------------------------------------------------------
> 
> (Updated March 16, 2013, 12:42 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> As title, I looked through all "MessageBox" uses in frameworks and fixed all occurances of QUrl::toString() I could find.
> 
> 
> Diffs
> -----
> 
>   kio/kio/kdirlister.cpp 058d149 
>   kio/kio/krun.cpp 76b7385 
>   kio/kio/paste.cpp 85a7d39 
>   kio/kio/renamedialog.cpp 54f136f 
> 
> Diff: http://git.reviewboard.kde.org/r/109519/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130316/543b1b72/attachment-0001.html>