Review Request 109516: Deprecate NetAccess::dircopy

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109516/#review29316
-----------------------------------------------------------



kio/kio/netaccess.h
<http://git.reviewboard.kde.org/r/109516/#comment21909>

    Yes, this could become KIO::file_copy + job->ui()->setWindow() + job->exec()



kio/kio/netaccess.h
<http://git.reviewboard.kde.org/r/109516/#comment21908>

    ... and remove the comment, and add a line to the api docs, saying:
    
     @deprecated since 5.0, use KIO::copy + job->ui()->setWindow() + job->exec() instead



kio/kio/netaccess.h
<http://git.reviewboard.kde.org/r/109516/#comment21910>

    And this should be deprecated in favour of KIO::del + the usual.



kio/kio/netaccess.h
<http://git.reviewboard.kde.org/r/109516/#comment21911>

    KIO::mkdir + setWindow + exec



staging/kemoticons/src/core/kemoticonsprovider.cpp
<http://git.reviewboard.kde.org/r/109516/#comment21912>

    0 is actually the default value, so this isn't useful


- David Faure


On March 16, 2013, 11:29 a.m., Àlex Fiestas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109516/
> -----------------------------------------------------------
> 
> (Updated March 16, 2013, 11:29 a.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Description
> -------
> 
> Patch only adds KDE_NO_DEPRECATED to both NetAccess::dircopy methods and ports KEmoticonsProvider away from it.
> 
> I was wondering if I should mark as deprecated some other static methods such file_copy.
> 
> 
> Diffs
> -----
> 
>   kio/kio/netaccess.h 3119c74 
>   kio/kio/netaccess.cpp fd50caa 
>   staging/kemoticons/src/core/kemoticonsprovider.cpp de073d8 
> 
> Diff: http://git.reviewboard.kde.org/r/109516/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Àlex Fiestas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130316/a6f6cd0c/attachment.html>