Review Request 109518: Remove apparently unused KCrash::setup

[Kevin Ottens]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109518/#review29315
-----------------------------------------------------------

Ship it!


Ship It!

- Kevin Ottens


On March 16, 2013, 12:54 p.m., Àlex Fiestas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109518/
> -----------------------------------------------------------
> 
> (Updated March 16, 2013, 12:54 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Checking how KCrash Q_COREAPP_STARTUP_FUNCTION porting was done I realized that there is a method not called or implemented by anyone (it is not even exported) in KCrash namespace.
> 
> Perhaps the intention was to rename kcrashInitialize to KCrash::setup ?
> 
> 
> Diffs
> -----
> 
>   kdeui/util/kcrash.cpp 0a41ae1 
> 
> Diff: http://git.reviewboard.kde.org/r/109518/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Àlex Fiestas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130316/8ac98b3a/attachment.html>