Review Request 109503: Compile with current qt dev branch

Stephen Kelly steveire at gmail.com
Fri Mar 15 17:07:10 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109503/#review29284
-----------------------------------------------------------


The problem is that build.kde.org uses qt5.git, which does not yet have that commit. Actually qt5.git hasn't been updated in 6 weeks: https://codereview.qt-project.org/#change,46445

If b.k.o can be updated to use the dev branches of the qt 5 submodules, I think that's a good idea. In general, I think it's a bad idea to use qt5.git or to recommend anyone else use it (as is currently recommended on the wiki).

At any rate, this patch shouldn't go in until b.k.o can build it.

- Stephen Kelly


On March 15, 2013, 4:59 p.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109503/
> -----------------------------------------------------------
> 
> (Updated March 15, 2013, 4:59 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> 34a3f2cd442ff1396e508f7a8890b968f1bb3179 has been merged to qtbase and now frameworks contains definitions of functions that clash with the ones from Qt itself
> 
> 
> Diffs
> -----
> 
>   kdecore/tests/kdatetimetest.cpp d64492b 
>   libkdeqt5staging/src/CMakeLists.txt 6572b92 
>   libkdeqt5staging/src/qtest_staging.h c2b081e 
>   staging/kde4support/src/kdecore/qtest_kde.h 7174893 
> 
> Diff: http://git.reviewboard.kde.org/r/109503/diff/
> 
> 
> Testing
> -------
> 
> Compiles
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130315/372e128a/attachment.html>


More information about the Kde-frameworks-devel mailing list